feat: add IPv6 support #5775
Open
feat: add IPv6 support #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close: vesoft-inc#4955 Now it should support dual stack for some friends in community. This roughly change is targeted to create a branch for their quick testing on IPv6 only env(that doesnt come with a DNS) Note intToIPv4 is not handled due to it's probabbly for metad of NebulaGraph v1 only.
Open
|
ping @congguosn , as talked via slack, you could give a try on your ipv6 env. |
|
It seems to work ❯ grep local_ip etc/nebula-graphd.conf
--local_ip=fdd5:4123:e98d:4a86:2832:4cff:fe06:4c4
❯ nebula-console -port 9669 -user root -p nebula -addr fdd5:4123:e98d:4a86:2832:4cff:fe06:4c4
Welcome to Nebula Graph!
(root@nebula) [(none)]> show hosts graph
+------------------------------------------+------+----------+---------+--------------+---------+
| Host | Port | Status | Role | Git Info Sha | Version |
+------------------------------------------+------+----------+---------+--------------+---------+
| "fdd5:4123:e98d:4a86:2832:4cff:fe06:4c4" | 9669 | "ONLINE" | "GRAPH" | "e1d7b0051" | "" |
+------------------------------------------+------+----------+---------+--------------+---------+
Got 1 rows (time spent 4.773ms/6.843921ms)
|
export CPPLINT_EXTENS=cpp,h
export CPPLINT_FILTER=-whitespace/indent,-build/include_what_you_use,-readability/todo,-build/include,-build/header_guard,-runtime/references,-build/c++11
.linters/cpp/cpplint.py --quiet --extensions=$CPPLINT_EXTENS \
--filter=$CPPLINT_FILTER --linelength=100 src/common/network/NetworkUtils.cpp
patch.diff from formatter cd src git apply --reject --whitespace=fix ../patch.diff
it turned out this case should be resolved properly in running env, as it's not a mock call. Thus we remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: #4955
Description:
Now it should support dual stack for some friends in the community. This rough change is targeted to create a branch for their quick testing on IPv6-only env(that unfortunately doesn't come with a DNS to mitigate with fqdn)
Note intToIPv4 is not handled due to it's probably for the metad of NebulaGraph v1 only.
thread on creating this pr: https://community-chat.nebula-graph.io/t/16091432/another-question-is-does-nebula-support-ipv6-and-data-migrat#65aae6a6-8b13-4be9-b874-e56de5bc0c82
Checklist:
Tests:
Affects:
Release notes:
IPv6 is supported but not fully tested.